[PATCH] D104601: [Preprocessor] Implement -fminimize-whitespace.

[Aaron Ballman via Phabricator via cfe-commits]

aaron.ballman added a comment.

In D104601#2916986 <https://reviews.llvm.org/D104601#2916986>, @Meinersbur wrote:

> In D104601#2916897 <https://reviews.llvm.org/D104601#2916897>, @aaron.ballman wrote:
>
>> In D104601#2916887 <https://reviews.llvm.org/D104601#2916887>, @Meinersbur wrote:
>>
>>> I am working on a fix, but I wouldn't mind reverting.
>>
>> I would be comfortable reverting the feature for Clang 13 and fixing forward on trunk (unless there's a need to revert from trunk temporarily, of course). Giving the feature a full release to bake isn't a bad outcome.
>
> While this means that ccache can only use this feature when `clang-14` is detected, I fully understand.

Correct -- that would be unfortunate as I believe you were hoping for this to be in Clang 13 for ccache support. My fear of having this in Clang 13 is that very early testing has found several breakages so I worry if we've not had enough time to shake all those out. Having a bit more time might build our confidence. (So the result, to me, should be either that we back this out of the Clang 13 branch if we're still worried or we patch the Clang 13 branch if we think we've got all the cases, but I want to make sure we don't leave it somewhere in the middle for the release branch.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104601/new/

https://reviews.llvm.org/D104601