[PATCH] D106431: [clang-tidy] Fix cppcoreguidelines-init-variables by removing the enum FixIt, and add support for initialization check of scoped enum.

gehry via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jul 30 07:36:22 PDT 2021


Sockke marked 2 inline comments as done.
Sockke added a comment.

In D106431#2913101 <https://reviews.llvm.org/D106431#2913101>, @aaron.ballman wrote:

> In D106431#2912589 <https://reviews.llvm.org/D106431#2912589>, @Sockke wrote:
>
>> Thank you for your reply! I generally understand what you mean, but there are three cases, namely, no diagnosis, providing diagnosis, and providing diagnosis & FixIt.  Only by judging whether "diagnosis" is null may fail to achieve the goal.  I have revised it a little bit, do you think that's alright? @aaron.ballman
>
> By how the code looks, you made the exact changes I was hoping to see. Thank you!

Cheers! Can it be merged? @aaron.ballman



================
Comment at: clang-tools-extra/docs/ReleaseNotes.rst:156
+
+  ⁣Added support for initialization check of the scoped enum
+
----------------
whisperity wrote:
> Unterminated sequence. Also, where is this feature implemented?
Before that, isIntegerType() would not treat scoped enum as an integer, so scoped enum was ignored. But isEnumeralType() will not.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106431/new/

https://reviews.llvm.org/D106431



More information about the cfe-commits mailing list