[PATCH] D106550: [PowerPC] Allow MMA builtins to accpet restrict qualified pointers

Nemanja Ivanovic via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jul 30 06:13:04 PDT 2021


nemanjai requested changes to this revision.
nemanjai added inline comments.
This revision now requires changes to proceed.


================
Comment at: clang/lib/Sema/SemaChecking.cpp:7306
         (!ExpectedType->isVoidPointerType() &&
-           ArgType.getCanonicalType() != ExpectedType))
+         (!ArgType.isRestrictQualified() &&
+          ArgType.getCanonicalType() != ExpectedType)))
----------------
Parentheses here seem superfluous. Also, am I reading this correctly? Does this mean that if the argument type is `__restrict` anything, we are accepting it? That is not the intent here. We don't want to accept just ANY restrict qualified type. We want to accept either: `ExpectedType` or `ExpectedType __restrict`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106550/new/

https://reviews.llvm.org/D106550



More information about the cfe-commits mailing list