[PATCH] D106934: [clangd] Do not inlay hints pertaining to code in other files

[Kadir Cetinkaya via Phabricator via cfe-commits]

kadircet added inline comments.


================
Comment at: clang-tools-extra/clangd/InlayHints.cpp:320
+    // file that was included after the preamble), do not show in that case.
+    if (AST.getSourceManager().getFileID(FileRange->getBegin()) != MainFileID)
+      return;
----------------
sammccall wrote:
> nit: getSourceManager().isWrittenInMainFile(FileRange->getBegin())
double nit: `isInsideMainFile(Loc, SM)`, I presume we would like to keep hints in preamble section as well (even though it is unlikely that we'll have any)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106934/new/

https://reviews.llvm.org/D106934