[PATCH] D106431: [clang-tidy] Fix cppcoreguidelines-init-variables by removing the enum FixIt, and add support for initialization check of scoped enum.

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jul 28 09:47:16 PDT 2021


aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.

LGTM -- it's not the cleanest solution (we're duplicating the call to `diag()`), but it'll suffice. If we wanted to clean it up a bit, we could use an `llvm::Optional<const char *> Diagnose  = llvm::None;` where a non-`None` value means "diagnose" and if the stored pointer value is not null, it additionally adds the fixit information.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106431/new/

https://reviews.llvm.org/D106431



More information about the cfe-commits mailing list