[PATCH] D105527: libclang.so: Make SONAME independent from LLVM version

Tom Stellard via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jul 26 18:59:13 PDT 2021


tstellar added inline comments.


================
Comment at: clang/tools/libclang/CMakeLists.txt:67
 
 set(LLVM_EXPORTED_SYMBOL_FILE ${CMAKE_CURRENT_SOURCE_DIR}/libclang.exports)
+set(LIBCLANG_VERSION_SCRIPT_FILE ${CMAKE_CURRENT_SOURCE_DIR}/libclang.map)
----------------
thakis wrote:
> This is still set to CURRENT_SOURCE_DIR. Is this set anywhere else, or does the action below create a file in the source dir now?
This was a mistake.  This has been changed in trunk now to generate into CMAKE_CURRENT_BINARY_DIR.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105527/new/

https://reviews.llvm.org/D105527



More information about the cfe-commits mailing list