[PATCH] D106375: Thread safety analysis: Mock getter for private mutexes can be undefined

Aaron Puchert via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jul 23 05:42:56 PDT 2021


aaronpuchert added a comment.

In D106375#2896484 <https://reviews.llvm.org/D106375#2896484>, @aaron.ballman wrote:

> LGTM! It took me a minute to convince myself it wasn't really an ODR use (the argument goes through the usual expression evaluation parsing and sema bits), but because the arguments to these attributes never wind up being used in codegen, they're not really a use as far as the ODR is concerned.

Right, the standard doesn't know about our attributes. My reasoning was that they are basically an unevaluated context like a `sizeof` expression.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106375/new/

https://reviews.llvm.org/D106375



More information about the cfe-commits mailing list