[PATCH] D105328: [Frontend] Only compile modules if not already finalized

Wed Jul 14 19:47:47 PDT 2021

vsapsai accepted this revision.
vsapsai added a comment.
This revision is now accepted and ready to land.

Have 1 punctuation nit (that I'm not sure about), the rest looks good.

================
Comment at: clang/lib/Serialization/ASTReader.cpp:2854
+        bool recompileFinalized =
+            Result == OutOfDate && Capabilities & ARR_OutOfDate &&
+            getModuleManager().getModuleCache().isPCMFinal(F.FileName);
----------------
I don't remember recommended LLVM style or if clang-tidy would complain about it but `... & ... && ...` can be unclear regarding the priority of operations. Personally, I would do `(... & ...) && ...` but I don't know what is the rule, so not insisting.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105328/new/

https://reviews.llvm.org/D105328