[PATCH] D105943: [clang-format++] Create a new variant of the clang-format tool to allow additional code mutating behaviour such as East/West Const Fixer

MyDeveloperDay via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jul 13 15:04:27 PDT 2021


MyDeveloperDay created this revision.
MyDeveloperDay added reviewers: curdeius, HazardyKnusperkeks, aaron.ballman.
MyDeveloperDay added projects: clang-format, clang.
Herald added a subscriber: mgorny.
MyDeveloperDay requested review of this revision.

There has been much discussion about the relative merits of including East/West in the existing clang-format over in D69764: [clang-format] Add East/West Const fixer capability <https://reviews.llvm.org/D69764> on and off over the last 18 months

It seem we could not get to a concencus if this functionality should/shouldn't exist in clang-format mainly on the grounds that it broke the fundamental belief that clang-format should not modify the code (a precedent that had already been broken with SortIncludes)

As a compromise I'm suggesting a new tool which allows the introduction of such rules that can alter the code as well as format it.  This allows those users who want to use this check to do so by switching to this binary.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D105943

Files:
  clang/docs/ClangFormatStyleOptions.rst
  clang/docs/ReleaseNotes.rst
  clang/include/clang/Format/Format.h
  clang/lib/Format/CMakeLists.txt
  clang/lib/Format/ContinuationIndenter.cpp
  clang/lib/Format/EastWestConstFixer.cpp
  clang/lib/Format/EastWestConstFixer.h
  clang/lib/Format/Format.cpp
  clang/lib/Format/FormatInternal.h
  clang/tools/CMakeLists.txt
  clang/tools/clang-format++/CMakeLists.txt
  clang/tools/clang-format++/ClangFormatPlusPlus.cpp
  clang/unittests/Format/FormatTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D105943.358440.patch
Type: text/x-patch
Size: 64468 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20210713/3ec22485/attachment-0001.bin>


More information about the cfe-commits mailing list