[PATCH] D105754: [PowerPC] Fix L[D|W]ARX Implementation

Kai Luo via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat Jul 10 21:41:50 PDT 2021


lkail added inline comments.


================
Comment at: clang/lib/CodeGen/CGBuiltin.cpp:997
 
+static llvm::Value *emitLoadReserveIntrinsic(CodeGenFunction &CGF,
+                                             unsigned BuiltinID,
----------------
Maybe rename to `emitPPCLoadReserveIntrinsic` should be more appropriate, since other targets also have similar load-reserve/load-linked/load-acquire notions and what this function does is ad hoc to PPC.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105754/new/

https://reviews.llvm.org/D105754



More information about the cfe-commits mailing list