[PATCH] D99381: [compiler-rt][hwasan] Add Fuchsia-specific sanitizer platform limits

Roland McGrath via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jul 5 13:40:04 PDT 2021


mcgrathr added a comment.

Frankly I don't think it makes sense to have __sanitizer_mallinfo and those other allocator functions declared in hwasan_interface_internal.h at all.
Those are neither APIs that the compiler emits nor ones that anyone else should use.  They are just implementation details of the allocator interceptors.
I think a better cleanup is to move those declarations out of that file.  I don't see why they need to be in any header file rather than just in hwasan_allocation_functions.cpp.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99381/new/

https://reviews.llvm.org/D99381



More information about the cfe-commits mailing list