[PATCH] D105400: [clangd][iwyu] explicitly includes `<atomic>`

Christopher Di Bella via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat Jul 3 19:19:40 PDT 2021


cjdb created this revision.
Herald added subscribers: usaxena95, kadircet, jfb, arphaman.
cjdb requested review of this revision.
Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov.
Herald added a project: clang-tools-extra.

Compiling clangd with Clang modules and libc++ revealed that
`support/Threading.h` uses `std::atomic` but wasn't including the
correct header.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D105400

Files:
  clang-tools-extra/clangd/support/Threading.h


Index: clang-tools-extra/clangd/support/Threading.h
===================================================================
--- clang-tools-extra/clangd/support/Threading.h
+++ clang-tools-extra/clangd/support/Threading.h
@@ -12,6 +12,7 @@
 #include "support/Context.h"
 #include "llvm/ADT/FunctionExtras.h"
 #include "llvm/ADT/Twine.h"
+#include <atomic>
 #include <cassert>
 #include <condition_variable>
 #include <future>


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D105400.356357.patch
Type: text/x-patch
Size: 422 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20210704/097d18eb/attachment.bin>


More information about the cfe-commits mailing list