[PATCH] D105254: [RISCV] Support machine constraint "S"

Fangrui Song via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jun 30 19:18:37 PDT 2021


MaskRay added inline comments.


================
Comment at: llvm/test/CodeGen/RISCV/inline-asm-S-constraint.ll:24
+; RV64-NEXT:    ret
+entry:
+  %0 = tail call i8* asm "lui $0, %hi($1)\0Aaddi $0,$0,%lo($1)", "=r,S"(i32* nonnull @var)
----------------
jrtc27 wrote:
> Label isn't needed
Omitting the entry label is allowed but having a label is canonical. Without it `%0` needs to be `%1`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105254/new/

https://reviews.llvm.org/D105254



More information about the cfe-commits mailing list