[PATCH] D88666: DirectoryWatcher: add an implementation for Windows

[Stella Stamenova via Phabricator via cfe-commits]

stella.stamenova added a comment.

I wasn't able to reproduce this locally by running *just* the DirectoryWatcher tests. I'm not running all of the clang tests repeatedly to see if I can get a repro that way.

The online tests appear to always hang either in the InitialScanAsync or InvalidatedWatcherAsync based on the log from the failures. We are using a non-OS drive for the tests, but it is not a network drive. The hang is also very consistent in our online testing - every couple of runs, sometimes more often. I suspect one of the reasons I cannot reproduce it locally with ease is that the test machines are able to run more tests in parallel and faster.

  [==========] Running 1 test from 1 test suite.
  
  [----------] Global test environment set-up.
  
  [----------] 1 test from DirectoryWatcherTest
  
  [ RUN      ] DirectoryWatcherTest.InvalidatedWatcherAsync
  
  
  ********************
  Testing:  0.. 10.. 20.. 30.. 40.. 50.. 60.. 70.. 80.. 90.. Terminate batch job (Y/N)? 
    interrupted by user, skipping remaining tests


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88666/new/

https://reviews.llvm.org/D88666