[PATCH] D103387: [clangd] Fix feature modules to drop diagnostics

Kadir Cetinkaya via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jun 17 00:17:43 PDT 2021


kadircet updated this revision to Diff 352628.
kadircet marked 2 inline comments as done.
kadircet added a comment.

- Bail out early before filling in diag info
- Move isExcluded check into handleDiagnostics, rather than handling it during

flushing


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103387/new/

https://reviews.llvm.org/D103387

Files:
  clang-tools-extra/clangd/Diagnostics.cpp
  clang-tools-extra/clangd/Diagnostics.h
  clang-tools-extra/clangd/unittests/FeatureModulesTests.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D103387.352628.patch
Type: text/x-patch
Size: 5025 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20210617/b9305ebc/attachment.bin>


More information about the cfe-commits mailing list