[PATCH] D104046: [analyzer] Simplify the process of producing notes for stores

[Artem Dergachev via Phabricator via cfe-commits]

NoQ accepted this revision.
NoQ added a comment.
This revision is now accepted and ready to land.

Looks great, thanks!



================
Comment at: clang/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp:1299
+  } else if (SI.Value.isUndef()) {
+    OS << "uninitialized value";
+
----------------
This isn't new but oof this note is terrible.

I don't think we have any tests where it's actually emitted. I suspect that this shouldn't happen in practice unless `core` checkers are disabled.

Now that I think of it, our actual warning for undef passed into function says "function call argument is an uninitialized value" which is almost as bad as this.

Just sayin' :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104046/new/

https://reviews.llvm.org/D104046