[PATCH] D104192: [clang][RISCV] Change implicit ARCH for explicitly specified ABI
Ben Shi via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Sun Jun 13 18:53:01 PDT 2021
benshi001 added a comment.
In D104192#2815757 <https://reviews.llvm.org/D104192#2815757>, @MaskRay wrote:
> The thing looks weird. My mental model (ppc) is that `-march` can infer `-mabi`, not the other way around...
The original way in Driver/Toolchains/Arch/RISCV.cpp is
if (MABI.equals_lower("ilp32e"))
return "rv32e";
else if (MABI.startswith_lower("ilp32"))
return "rv32imafdc";
else if (MABI.startswith_lower("lp64"))
return "rv64imafdc";
So you think we should delete it entirely?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D104192/new/
https://reviews.llvm.org/D104192
More information about the cfe-commits
mailing list