[PATCH] D104071: [AST] Include the TranslationUnitDecl when traversing with TraversalScope

Sam McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jun 11 05:29:27 PDT 2021


sammccall added a comment.

In D104071#2812870 <https://reviews.llvm.org/D104071#2812870>, @hokein wrote:

> Per https://reviews.llvm.org/harbormaster/unit/view/779496/, window test seems to be failing...

Oops, there was a test I forgot to update (failed on all platforms). Fixed.

> Thanks! I think we should probably document this RAV behavior change in the release note.

Happy to do this if you like, but I wouldn't be inclined - there are no in-tree uses of setTraversalScope apart from clangd, and in google's internal codebase (quite a lot of clang API usage) I only found one caller and no changes were needed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104071/new/

https://reviews.llvm.org/D104071



More information about the cfe-commits mailing list