[clang] cf11d95 - Fix to Windows temp file change.

Amy Huang via cfe-commits cfe-commits at lists.llvm.org
Wed Jun 9 16:24:05 PDT 2021


Author: Amy Huang
Date: 2021-06-09T16:15:16-07:00
New Revision: cf11d9585afd5c43031aaaaa9fb622c8c31b4bef

URL: https://github.com/llvm/llvm-project/commit/cf11d9585afd5c43031aaaaa9fb622c8c31b4bef
DIFF: https://github.com/llvm/llvm-project/commit/cf11d9585afd5c43031aaaaa9fb622c8c31b4bef.diff

LOG: Fix to Windows temp file change.

Original change passed wrong parameters to the raw_fd_ostream ctor.
Fixes a bug in https://reviews.llvm.org/D102736.

Added: 
    

Modified: 
    clang/lib/Frontend/CompilerInstance.cpp

Removed: 
    


################################################################################
diff  --git a/clang/lib/Frontend/CompilerInstance.cpp b/clang/lib/Frontend/CompilerInstance.cpp
index a70fe95800e1..78c7d84bbef4 100644
--- a/clang/lib/Frontend/CompilerInstance.cpp
+++ b/clang/lib/Frontend/CompilerInstance.cpp
@@ -853,9 +853,7 @@ CompilerInstance::createOutputFileImpl(StringRef OutputPath, bool Binary,
       consumeError(std::move(E));
     } else {
       Temp = std::move(ExpectedFile.get());
-      OS.reset(new llvm::raw_fd_ostream(Temp->FD, /*shouldClose=*/false,
-                                        Binary ? llvm::sys::fs::OF_None
-                                               : llvm::sys::fs::OF_Text));
+      OS.reset(new llvm::raw_fd_ostream(Temp->FD, /*shouldClose=*/false));
       OSFile = Temp->TmpName;
     }
     // If we failed to create the temporary, fallback to writing to the file


        


More information about the cfe-commits mailing list