[PATCH] D101868: [clang-format] Adds a formatter for aligning arrays of structs

Fred Grim via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jun 9 12:53:00 PDT 2021


feg208 marked an inline comment as done.
feg208 added a comment.

In D101868#2808826 <https://reviews.llvm.org/D101868#2808826>, @curdeius wrote:

> LGTM. That's a great piece work @feg208. Thank you!

Awww thanks. I learned a lot from all the comments honestly. I appreciate the patience.

> I've added many nit comments, but I didn't do it for all code comments.
> Please check that all comments are full phrases (with full stops :) ) before landing.
> Some comments are in .rst but you know that you need to update Format.h and then regenerate .rst :).
> Also, don't hesitate to mark comments as done.

I'll roll these up.

> Do you need somebody to land it on your behalf?

I do. I don't have commit rights


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101868/new/

https://reviews.llvm.org/D101868



More information about the cfe-commits mailing list