[PATCH] D103664: [Windows SEH]: Fix -O2 crash for Windows -EHa

Zahira Ammarguellat via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jun 4 13:17:40 PDT 2021


zahiraam added a comment.

In D103664#2799852 <https://reviews.llvm.org/D103664#2799852>, @tentzen wrote:

> @zahiraam, are you removing all those CHECKs:
>
> - CHECK: invoke void @llvm.seh.scope.**
>
> those are placed there to ensure SEH scope semantic is preserved for Od..

I was just showing you. The checks generated at O2 <https://reviews.llvm.org/owners/package/2/> are only the ones that I have left. At O0 the checks need to stay. So you need to rewrite the LIT tests so that both are expected for one option and the other.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103664/new/

https://reviews.llvm.org/D103664



More information about the cfe-commits mailing list