[PATCH] D102906: [clang-tidy] Remark was added to clang tooling Diagnostic

[Ivan Murashko via Phabricator via cfe-commits]

ivanmurashko marked an inline comment as done.
ivanmurashko added a comment.

Hi @aaron.ballman

> Thanks! Do you need someone to commit on your behalf?

I will appreciate your assistance in the landing the diff.

> If so, what name and email address would you like used for patch attribution?

It would be good to use mine - Ivan Murashko (ivan.murashko at gmail.com) for that



================
Comment at: clang/include/clang/Tooling/Core/Diagnostic.h:72
+    Error = DiagnosticsEngine::Error,
+    Remark = DiagnosticsEngine::Remark
   };
----------------
aaron.ballman wrote:
> DmitryPolukhin wrote:
> > nit, I would move remark first to have list by increasing severity. It looks like this enum values is not used outside of the sources so I hope it is safe.
> We have diagnostic notes as well and it's not clear to me how to order remark and note should we go that way in the future. So I'm not opposed to the suggestion, but the order likely doesn't matter all that much.
@DmitryPolukhin fixed


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102906/new/

https://reviews.llvm.org/D102906