[PATCH] D93565: scan-view: Remove Reporter.py and associated AppleScript files

Ben Jackson via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu May 20 03:33:19 PDT 2021


puremourning added a comment.

In D93565#2770709 <https://reviews.llvm.org/D93565#2770709>, @puremourning wrote:

> Unless i'm missing something, this change seems to have broken scan-view, as it now just says
>
> "ModuleNotFOundError: No module named 'Reporter'"
>
> Due to :
>
> `import Reporter` in `ScanView.py`
>
> Am i losing my mind?

This seems to fix it:

  index 5a5d15e85b30..4eccb9958a05 100644
  --- a/clang/tools/scan-view/share/ScanView.py
  +++ b/clang/tools/scan-view/share/ScanView.py
  @@ -26,7 +26,6 @@ import time
   import socket
   import itertools
  
  -import Reporter
   try:
       import configparser
   except ImportError:
  Stage this hunk [y,n,q,a,d,j,J,g,/,e,?]? y
  @@ -775,9 +774,7 @@ File Bug</h3>
  
  
   def create_server(address, options, root):
  -    import Reporter
  -
  -    reporters = Reporter.getReporters()
  +    reporters = []
  
       return ScanViewServer(address, ScanViewRequestHandler,
                             root,


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93565/new/

https://reviews.llvm.org/D93565



More information about the cfe-commits mailing list