[PATCH] D102556: [HIP] Fix spack detection

Artem Belevich via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon May 17 09:13:10 PDT 2021


tra accepted this revision.
tra added a comment.
This revision is now accepted and ready to land.

LGTM with a test nit.



================
Comment at: clang/test/Driver/rocm-detect.hip:115
+
+// SPACK-MISS-SILENT-NOT: SPACK package hip-4.0.0 not found at
+// SPACK-MISS-SILENT-NOT: SPACK package rocm-device-libs-4.0.0 not found at
----------------
Nit: I'd match the version with a regex. Otherwise this test would continue passing even if compiler were to report `hip-some.other.version not found` 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102556/new/

https://reviews.llvm.org/D102556



More information about the cfe-commits mailing list