[PATCH] D102577: TreeTransform.h: make the switch case more beautiful

[zhouyizhou via Phabricator via cfe-commits]

zhouyizhou created this revision.
zhouyizhou added reviewers: sepavloff, craig.topper, rsmith, klimek, doug.gregor.
Herald added a subscriber: pengfei.
zhouyizhou requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.

Hi,                                                                                                                                                                                                         
I am new to LLVM, and I really want to get involved in LLVM community.

                                                                                                                              

I guess if the following switch case of function                                                                                                                                                            
TransformNestedNameSpecifierLoc could possibly made more beautiful with                                                                                                                                     
'break' stmt moved inside of the right brace.

                                                                                                                              

I think move of 'break' stmt will not change the invoking destructor of                                                                                                                                     
IdInfo.

                                                                                                                              

Thanks for your effort.

                                                                                                                              

I have done make check-all on x86_64-linux                                                                                                                                                                  
Signed-off-by: Zhouyi Zhou <zhouzhouyi at gmail.com>


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D102577

Files:
  clang/lib/Sema/TreeTransform.h


Index: clang/lib/Sema/TreeTransform.h
===================================================================
--- clang/lib/Sema/TreeTransform.h
+++ clang/lib/Sema/TreeTransform.h
@@ -3964,8 +3964,8 @@
       if (SemaRef.BuildCXXNestedNameSpecifier(/*Scope=*/nullptr, IdInfo, false,
                                               SS, FirstQualifierInScope, false))
         return NestedNameSpecifierLoc();
-    }
       break;
+    }
 
     case NestedNameSpecifier::Namespace: {
       NamespaceDecl *NS


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D102577.345705.patch
Type: text/x-patch
Size: 502 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20210516/921552b9/attachment.bin>