[PATCH] D101387: [Clang] remove text extension from diag::err_drv_invalid_value_with_suggestion

Fangrui Song via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon May 3 11:13:29 PDT 2021


MaskRay accepted this revision.
MaskRay added a comment.
This revision is now accepted and ready to land.

One last nit. Perhaps leave it open for two days in case other reviewers have further comments.



================
Comment at: clang/include/clang/Basic/DiagnosticDriverKinds.td:279
   "-fembed-bitcode is not supported on versions of iOS prior to 6.0">;
+def err_drv_negative_columns : Error<
+    "invalid value '%1' in '%0', value must be 'none' or a positive integer">;
----------------
The two can reuse `err_drv_invalid_value_with_suggestion`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101387/new/

https://reviews.llvm.org/D101387



More information about the cfe-commits mailing list