[PATCH] D99840: [clang-format] Correctly attach enum braces with ShortEnums disabled

Marek Kurdej via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Apr 27 01:45:02 PDT 2021


curdeius accepted this revision.
curdeius added a comment.
This revision is now accepted and ready to land.

LGTM. I also consider it a bug. LLVM should not be affected as it uses `AllowShortEnumsOnASingleLine: true` whereas this problem arises only with `AllowShortEnumsOnASingleLine: false`.
Anyway, those that find the new behaviour problematic, can always set `BreakBeforeBraces: Custom` and `BraceWrapping.AfterEnum: true` to get the old behaviour.
@lunasorcery, please update release notes before landing.
If you don't have commit rights, please provide "Your Name <email at address>" for commit attribution, otherwise we'll use the name/email associated with you Phabricator account.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99840/new/

https://reviews.llvm.org/D99840



More information about the cfe-commits mailing list