[PATCH] D85802: [clang] Add -fc++-abi= flag for specifying which C++ ABI to use

Tue Apr 27 00:16:24 PDT 2021

jansvoboda11 added a comment.

In D85802#2717684 <https://reviews.llvm.org/D85802#2717684>, @leonardchan wrote:

>> That's odd. Does your `CMakeCache.txt` file have `CLANG_ROUND_TRIP_CC1_ARGS:BOOL=OFF` by any chance? It's possible it didn't get switched to `ON` when D97462 <https://reviews.llvm.org/D97462> landed.
>>
>> With the way the tests are written now, I'd expect them to fail in assert build without the code generating `-fcxx-abi=`.
>
> Ah, I did not have that flag ON by default (incrementally working off an old invocation), and turning this on without the `GenerateArg` bit causes `cxx-abi-switch.cpp` to fail. Thanks for catching this!

Great, thanks for confirming.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85802/new/

https://reviews.llvm.org/D85802