[PATCH] D75844: [clang] Set begin loc on GNU attribute parsed attrs

Brooks Moses via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Apr 8 11:31:03 PDT 2021


brooksmoses added a comment.

FWIW, this now causes Clang to produce an error on this code, when it didn't before:

  using namespace::foo __attribute__((deprecated("message")));

I discussed this with Richard Smith, who points out that GCC does not accept this and it's not permitted according to the C++ standard, so this should probably be considered an accidental fix of a longstanding bug.   With that said, would it be useful to add this as a tested case?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75844/new/

https://reviews.llvm.org/D75844



More information about the cfe-commits mailing list