[PATCH] D99949: [AMDGPU][OpenMP] Add amdgpu-arch tool to list AMD GPUs installed

Pushpinder Singh via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Apr 7 02:24:48 PDT 2021


pdhaliwal updated this revision to Diff 335761.
pdhaliwal marked 10 inline comments as done.
pdhaliwal added a comment.

Addressed review comments.

RE test: Since the tool is contingent on the results of HSA API call, adding a test
which would always PASS on all the systems with different AMD GPUs as well as always ignored on systems
with non AMDGPUs would not work. I welcome suggestions on how to resolve this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99949/new/

https://reviews.llvm.org/D99949

Files:
  clang/lib/Driver/ToolChains/AMDGPU.cpp
  clang/lib/Driver/ToolChains/AMDGPU.h
  clang/lib/Driver/ToolChains/AMDGPUOpenMP.cpp
  clang/tools/CMakeLists.txt
  clang/tools/amdgpu-arch/AMDGPUArch.cpp
  clang/tools/amdgpu-arch/CMakeLists.txt

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D99949.335761.patch
Type: text/x-patch
Size: 7929 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20210407/4b7728a4/attachment-0001.bin>


More information about the cfe-commits mailing list