[PATCH] D99715: [CMake] Respect LLVM_MINIMUM_PYTHON_VERSION in Tooling/CMakeLists.txt

Dominik Montada via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Apr 1 03:29:33 PDT 2021


gargaroff created this revision.
gargaroff added reviewers: serge-sans-paille, dblaikie, jyknight, JDevlieghere, yln, efriedma, ctetreau.
Herald added a subscriber: mgorny.
gargaroff requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.

This will override the found Python3 from llvm/CMakeLists.txt and cause
tests to fail if that version turns out to be lower than the minimum
version required to run tests.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D99715

Files:
  clang/lib/Tooling/CMakeLists.txt


Index: clang/lib/Tooling/CMakeLists.txt
===================================================================
--- clang/lib/Tooling/CMakeLists.txt
+++ clang/lib/Tooling/CMakeLists.txt
@@ -13,7 +13,7 @@
 add_subdirectory(DependencyScanning)
 add_subdirectory(Transformer)
 
-find_package(Python3 COMPONENTS Interpreter)
+find_package(Python3 ${LLVM_MINIMUM_PYTHON_VERSION} COMPONENTS Interpreter)
 
 # Replace the last lib component of the current binary directory with include
 string(FIND ${CMAKE_CURRENT_BINARY_DIR} "/lib/" PATH_LIB_START REVERSE)


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D99715.334638.patch
Type: text/x-patch
Size: 548 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20210401/b81d191f/attachment.bin>


More information about the cfe-commits mailing list