[PATCH] D73967: Implement _ExtInt as an extended int type specifier.

Ronan Keryell via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Mar 26 13:33:31 PDT 2021


keryell added a comment.

In D73967#2653250 <https://reviews.llvm.org/D73967#2653250>, @erichkeane wrote:

> 



>> It comes from an FPGA tool programmer who knows about HLS *and* modern C++, so probably a very rare specie. :-)
>> The typical FPGA programmer and tool writer is often more focused on C, so knows barely nothing about generic programming.



> Our FPGA team DOES know HLS and (most of) modern C++, they are the implementers of https://www.intel.com/content/www/us/en/software/programmable/quartus-prime/hls-compiler.html.

"Uses untimed ANSI C++ as the golden design source": is this pre ISO C++98? :-)
Perhaps you should put ISO C++ with some version number there.

Kidding aside, the HLS world comes historically from the C world and thus solves problem in the `#pragma` and `__attribute__`. And there is some value in this for customers not wanting to dive into C++ and just having minimal change to the code besides these `#pragma`. But a the same time it is done with a lot of atrocities on the type system when extending this to C++...

> That said, I can see potential value (though the SFINAE to get the unsigned vs signed seems easy enough), but would suggest either the WG14 paper, or to suggest it to the authors of the WG14 paper and see what they say.  Feel free to include me in the chain.

I am not following at all the WG14 papers. I have enough pain just running after the C++ papers... :-( But I might have a look on this one...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73967/new/

https://reviews.llvm.org/D73967



More information about the cfe-commits mailing list