[PATCH] D98037: [clangd] Add config block for Completion and option for AllScopes

Sam McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Mar 11 11:07:14 PST 2021


sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.


================
Comment at: clang-tools-extra/clangd/ConfigFragment.h:244
+  struct CompletionBlock {
+    /// Whether code completion should include results from scopes that are not
+    /// visible.
----------------
Maybe s/results/suggestions/, emphasizing that these are going to be guesses?

Consider also "The required scope prefix will be inserted."


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98037/new/

https://reviews.llvm.org/D98037



More information about the cfe-commits mailing list