[PATCH] D93938: [clang-format] Fixed AfterEnum handling

Ally Tiritoglu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Mar 8 20:43:38 PST 2021


atirit added a comment.

In D93938#2610568 <https://reviews.llvm.org/D93938#2610568>, @curdeius wrote:

> I hadn't had another look, because the CI still shows the test `AfterEnum` to be failing.

I know the test fails; it's due to a separate bug wherein `AfterEnum: true` and `AllowShortEnumsOnASingleLine: true` produces incorrect behaviour. The unit test has the correct expectation. I've also already mentioned this.

In D93938#2476691 <https://reviews.llvm.org/D93938#2476691>, @atirit wrote:

> The first test fails due to the aforementioned corner case.

I could modify the unit test to expect the currently broken behaviour and then fix the test later alongside a fix for the corner case.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93938/new/

https://reviews.llvm.org/D93938



More information about the cfe-commits mailing list