[PATCH] D97965: [clang] Fix crash when creating deduction guide.

Haojian Wu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun Mar 7 23:55:01 PST 2021


hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.

Thanks!



================
Comment at: clang/test/SemaCXX/cxx1z-class-template-argument-deduction.cpp:425
+  // This used to crash due to unparsed default arg above.
+  B(); // expected-error {{deduction guide declaration without trailing return type}}
+};
----------------
The diagnostic seems bogus, but I think it is at least better than crashing, I'd add add a FIXME to fix this bogus diagnostic here?.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97965/new/

https://reviews.llvm.org/D97965



More information about the cfe-commits mailing list