[PATCH] D98075: [Matrix] Implement += and -= for MatrixType

Saurabh Jha via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun Mar 7 01:07:15 PST 2021


SaurabhJha added a comment.

In D98075#2609074 <https://reviews.llvm.org/D98075#2609074>, @fhahn wrote:

> Thanks for the patch! Could you also extend the Sema `matrix-type-operators` tests with checks for `+=` & `-=`?
>
> It looks like the handling for multiply is slightly different and already works but is missing test coverage. It would be great if you could also extend the tests to check for `*=`.

Thanks for the review. I have addressed your comments.

We don't need to add anything to `CodeGenCXX/matrix-type-operators.cpp` and `SemaCXX/matrix-type-operators.cpp`, right?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98075/new/

https://reviews.llvm.org/D98075



More information about the cfe-commits mailing list