[PATCH] D97058: [OpenCL] Refactor diagnostic for OpenCL extension/feature

[Anton Zabaznov via Phabricator via cfe-commits]

azabaznov added a comment.

> FYI, I would even be ok if we remove the need for enabling non-core

AFAIU this can be done not for every extension to maintain backward compatibility. In this case I think https://reviews.llvm.org/D97052 can be useful.

Also, I imagine that implicit type definition is not  needed if no pragma required.



================
Comment at: clang/lib/Sema/Sema.cpp:360
 
     setOpenCLExtensionForType(Context.DoubleTy, "cl_khr_fp64");
 
----------------
Anastasia wrote:
> I think the same should apply to `double` not only `atomic_double`?
I think `double` is created in a place where it's not possible to guard it with OpenCL extensions support. I will double-check.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97058/new/

https://reviews.llvm.org/D97058