[PATCH] D96852: [clang][SVE] Remove inline keyword from arm_sve.h

Joe Ellis via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Feb 17 03:05:28 PST 2021


joechrisellis created this revision.
joechrisellis added reviewers: DavidTruby, peterwaller-arm, paulwalker-arm, bsmith.
Herald added subscribers: psnobl, kristof.beyls, tschuett.
Herald added a reviewer: efriedma.
joechrisellis requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.

The inline keyword is not defined in the C89 standard, so source files
that include arm_sve.h will fail compilation if -std=c89 is specified.
We already use the __always_inline__ function attribute so the inline
keyword here is redundant anyway.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D96852

Files:
  clang/utils/TableGen/SveEmitter.cpp


Index: clang/utils/TableGen/SveEmitter.cpp
===================================================================
--- clang/utils/TableGen/SveEmitter.cpp
+++ clang/utils/TableGen/SveEmitter.cpp
@@ -1201,7 +1201,7 @@
   OS << "};\n\n";
 
   OS << "/* Function attributes */\n";
-  OS << "#define __aio static inline __attribute__((__always_inline__, "
+  OS << "#define __aio static __attribute__((__always_inline__, "
         "__nodebug__, __overloadable__))\n\n";
 
   // Add reinterpret functions.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D96852.324256.patch
Type: text/x-patch
Size: 498 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20210217/2b29a61a/attachment.bin>


More information about the cfe-commits mailing list