[PATCH] D96607: [clang-tidy] Add check 'readability-pointer-type-star-placement'.

Eugene Zelenko via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Feb 12 15:25:23 PST 2021


Eugene.Zelenko added a comment.

I think it'll be much more reasonable to use `clang-format` and filter its output to select only changes with stars in build rule. `clang-format-diff` is another method to introduce formatting changes gradually.



================
Comment at: clang-tools-extra/clang-tidy/readability/PointerTypeStarPlacementCheck.cpp:1
+//===--- PointerTypeStarPlacementCheck.cpp - clang-tidy
+//---------------------===//
----------------
Two lines must be joined.


================
Comment at: clang-tools-extra/clang-tidy/readability/PointerTypeStarPlacementCheck.h:19
+///
+///
+///
----------------
Some description should be provided, or empty comment removed.


================
Comment at: clang-tools-extra/docs/ReleaseNotes.rst:70
 
-The improvements are...
+- Checks that allow configuring names of headers to include now support wrapping
+  the include in angle brackets to create a system include. For example,
----------------
Merge artifact?


================
Comment at: clang-tools-extra/docs/clang-tidy/checks/readability-pointer-type-star-placement.rst:10
+checked.
+
+
----------------
Please remove empty line.


================
Comment at: clang-tools-extra/docs/clang-tidy/checks/readability-pointer-type-star-placement.rst:28
+
+Options
+-------
----------------
Copy-paste error?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96607/new/

https://reviews.llvm.org/D96607



More information about the cfe-commits mailing list