[PATCH] D96578: [clangd] Remove the cross-file-rename option.

[Haojian Wu via Phabricator via cfe-commits]

hokein added inline comments.


================
Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:237
-    IsMainFileOnly = false;
-  // If the symbol is not indexable, we disallow rename.
-  if (!SymbolCollector::shouldCollectSymbol(
----------------
sammccall wrote:
> I don't understand why we're now allowing rename of non-indexable symbols.
> Is this really intended? At the least it seems like an unrelated change.
oh, you're right. I didn't think it too much when removing the code.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96578/new/

https://reviews.llvm.org/D96578