[PATCH] D95812: [clangd] Report only decl of overridding method in xref.

[Utkarsh Saxena via Phabricator via cfe-commits]

usaxena95 added a comment.

In D95812#2535077 <https://reviews.llvm.org/D95812#2535077>, @sammccall wrote:

> This looks about right to me...
> Unfortunately I landed ff4832dbff0ccf1fd29f726efe72fd1220cd645a <https://reviews.llvm.org/rGff4832dbff0ccf1fd29f726efe72fd1220cd645a> and 1eb7fd089e2fcf3fe211f865b28e2fed12128c3f <https://reviews.llvm.org/rG1eb7fd089e2fcf3fe211f865b28e2fed12128c3f> meanwhile so this will need a rebase :-(
>
> The first of those patches introduces flags on returned refs to indicate which are decls/defs. I'd suggest adding an "override" flag and populating it for these results.

Thanks.

> (I guess the bug includes the other side of this, where if the method is an override, calls to base methods are reported. Makes sense to split it into a separate patch...)

Yes. I plan to do that in a separate patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95812/new/

https://reviews.llvm.org/D95812