[PATCH] D95534: clang-cl: Invent a /winsysroot concept

[Nico Weber via Phabricator via cfe-commits]

thakis added inline comments.


================
Comment at: clang/test/Driver/cl-sysroot.cpp:10
+
+// CHECK: "-internal-isystem" "[[ROOT]]/VC/Tools/MSVC/14.26.28801/include"
+// CHECK: "-internal-isystem" "[[ROOT]]/VC/Tools/MSVC/14.26.28801/atlmfc/include"
----------------
hans wrote:
> could the slashes be backslashes when this test runs on a windows machine?
Yes, thanks. Even worse, the whole -DFOO=%t approach doesn't work because clang escapes %t for the driver, which double all the slashes etc. Instead gave the toolsdir a number that no real msvc install should use and then captured the root dir via filecheck from there.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95534/new/

https://reviews.llvm.org/D95534