[PATCH] D95439: [clangd] Add include-fixer fixit for field_incomplete_or_sizeless diagnostic.

[Haojian Wu via Phabricator via cfe-commits]

hokein marked an inline comment as done.
hokein added inline comments.


================
Comment at: clang-tools-extra/clangd/IncludeFixer.cpp:81
   case diag::err_func_def_incomplete_result:
+  case diag::err_field_incomplete_or_sizeless:
     // Incomplete type diagnostics should have a QualType argument for the
----------------
kadircet wrote:
> what about the `sizless` case ? we'll attach a fixit, but it is not going to fix the issue :(
The [sizeless](https://reviews.llvm.org/D62962) type is a clang extension, I think our indexer doesn't index this kind of symbols, so we will not attach a fixit for them. 

And I think sizeless case is rare in practice, I would not too worry about it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95439/new/

https://reviews.llvm.org/D95439