[PATCH] D93579: [clang][AVR] Improve avr-ld command line options

[Fangrui Song via Phabricator via cfe-commits]

MaskRay requested changes to this revision.
MaskRay added inline comments.
This revision now requires changes to proceed.


================
Comment at: clang/lib/Driver/ToolChains/AVR.cpp:37
 } MCUInfo[] = {
     {"at90s1200", "", "avr1"},
     {"attiny11", "", "avr1"},
----------------
This may cause -Wmissing-field-initializers, please fix


================
Comment at: clang/test/Driver/avr-ld.c:2
+// RUN: %clang -### --target=avr -mmcu=at90s2313 %s 2>&1 | FileCheck -check-prefix LINKA %s
+// LINKA: {{".*ld.*"}} {{.*}} {{"-L.*tiny-stack"}} {{.*}} "-Tdata=0x800060" {{.*}} "-lat90s2313" "-mavr2"
+
----------------
You need `--sysroot` and a mock `ld` file in the tree.

See lto.c


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93579/new/

https://reviews.llvm.org/D93579