[PATCH] D94067: [clang][ASTImporter] Fix a possible assertion failure `NeedsInjectedClassNameType(Decl)'.

Shafik Yaghmour via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jan 6 09:32:02 PST 2021


shafik added inline comments.


================
Comment at: clang/lib/AST/ASTImporter.cpp:2901
+          // Skip the declaration if injected type is already set.
+          if (isa<InjectedClassNameType>(RI->getTypeForDecl()))
+            continue;
----------------
balazske wrote:
> shafik wrote:
> > Is this to fix the bug or is this for efficiency sake?
> This is not needed for the fix, it was used in the first version of the fix (still only for efficiency). In the current form this looks like unrelated change (the old fix included other code at the same location) so I am not against removing this part (but add it in a separate change).
Yes, please if we can split the two changes that would be great.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94067/new/

https://reviews.llvm.org/D94067



More information about the cfe-commits mailing list