[PATCH] D94067: [clang][ASTImporter] Fix a possible assertion failure `NeedsInjectedClassNameType(Decl)'.
Balázs Kéri via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Jan 5 01:06:13 PST 2021
balazske added a comment.
The exact call chain, if the added test is called without the fix:
$ ./tools/clang/unittests/AST/ASTTests --gtest_filter='*HasNoDescribedTemplateSet*'
Note: Google Test filter = *HasNoDescribedTem*
[==========] Running 4 tests from 1 test case.
[----------] Global test environment set-up.
[----------] 4 tests from ParameterizedTests/ASTImporterOptionSpecificTestBase
[ RUN ] ParameterizedTests/ASTImporterOptionSpecificTestBase.ImportOfTemplatedDeclWhenPreviousDeclHasNoDescribedTemplateSet/0
ASTTests: llvm-project/clang/lib/AST/ASTContext.cpp:4411: clang::QualType clang::ASTContext::getInjectedClassNameType(clang::CXXRecordDecl*, clang::QualType) const: Assertion `NeedsInjectedClassNameType(Decl)' failed.
#0 0x00007feb23200d2e llvm::sys::PrintStackTrace(llvm::raw_ostream&, int) llvm-project/llvm/lib/Support/Unix/Signals.inc:563:0
#1 0x00007feb23200de5 PrintStackTraceSignalHandler(void*) llvm-project/llvm/lib/Support/Unix/Signals.inc:630:0
#2 0x00007feb231feac9 llvm::sys::RunSignalHandlers() llvm-project/llvm/lib/Support/Signals.cpp:71:0
#3 0x00007feb232006b0 SignalHandler(int) llvm-project/llvm/lib/Support/Unix/Signals.inc:405:0
#4 0x00007feb279da980 __restore_rt (/lib/x86_64-linux-gnu/libpthread.so.0+0x12980)
#5 0x00007feb226f1fb7 raise /build/glibc-S9d2JN/glibc-2.27/signal/../sysdeps/unix/sysv/linux/raise.c:51:0
#6 0x00007feb226f3921 abort /build/glibc-S9d2JN/glibc-2.27/stdlib/abort.c:81:0
#7 0x00007feb226e348a __assert_fail_base /build/glibc-S9d2JN/glibc-2.27/assert/assert.c:89:0
#8 0x00007feb226e3502 (/lib/x86_64-linux-gnu/libc.so.6+0x30502)
#9 0x00007feb248a9b3f clang::ASTContext::getInjectedClassNameType(clang::CXXRecordDecl*, clang::QualType) const llvm-project/clang/lib/AST/ASTContext.cpp:4412:0
#10 0x00007feb2499eac4 clang::ASTNodeImporter::VisitRecordDecl(clang::RecordDecl*) llvm-project/clang/lib/AST/ASTImporter.cpp:2898:0
#11 0x00007feb24a22700 clang::declvisitor::Base<std::add_pointer, clang::ASTNodeImporter, llvm::Expected<clang::Decl*> >::VisitCXXRecordDecl(clang::CXXRecordDecl*) build/Debug/tools/clang/include/clang/AST/DeclNodes.inc:263:0
#12 0x00007feb249fcf60 clang::declvisitor::Base<std::add_pointer, clang::ASTNodeImporter, llvm::Expected<clang::Decl*> >::Visit(clang::Decl*) build/Debug/tools/clang/include/clang/AST/DeclNodes.inc:263:0
#13 0x00007feb249c5ca1 clang::ASTImporter::ImportImpl(clang::Decl*) llvm-project/clang/lib/AST/ASTImporter.cpp:8119:0
#14 0x00007feb249c6c53 clang::ASTImporter::Import(clang::Decl*) llvm-project/clang/lib/AST/ASTImporter.cpp:8281:0
#15 0x00007feb249f3d21 llvm::Error clang::ASTNodeImporter::importInto<clang::CXXRecordDecl>(clang::CXXRecordDecl*&, clang::CXXRecordDecl*) llvm-project/clang/lib/AST/ASTImporter.cpp:155:0
#16 0x00007feb249af273 clang::ASTNodeImporter::VisitClassTemplateDecl(clang::ClassTemplateDecl*) llvm-project/clang/lib/AST/ASTImporter.cpp:5407:0
#17 0x00007feb249fce9c clang::declvisitor::Base<std::add_pointer, clang::ASTNodeImporter, llvm::Expected<clang::Decl*> >::Visit(clang::Decl*) build/Debug/tools/clang/include/clang/AST/DeclNodes.inc:207:0
#18 0x00007feb249c5ca1 clang::ASTImporter::ImportImpl(clang::Decl*) llvm-project/clang/lib/AST/ASTImporter.cpp:8119:0
#19 0x00007feb249c6c53 clang::ASTImporter::Import(clang::Decl*) llvm-project/clang/lib/AST/ASTImporter.cpp:8281:0
#20 0x00007feb249e53c9 llvm::Expected<clang::Decl*> clang::ASTNodeImporter::import<clang::Decl>(clang::Decl*) llvm-project/clang/lib/AST/ASTImporter.cpp:165:0
#21 0x00007feb2499735e clang::ASTNodeImporter::ImportDeclContext(clang::DeclContext*, bool) llvm-project/clang/lib/AST/ASTImporter.cpp:1761:0
#22 0x00007feb2499b408 clang::ASTNodeImporter::VisitNamespaceDecl(clang::NamespaceDecl*) llvm-project/clang/lib/AST/ASTImporter.cpp:2385:0
#23 0x00007feb249fcd4c clang::declvisitor::Base<std::add_pointer, clang::ASTNodeImporter, llvm::Expected<clang::Decl*> >::Visit(clang::Decl*) build/Debug/tools/clang/include/clang/AST/DeclNodes.inc:111:0
#24 0x00007feb249c5ca1 clang::ASTImporter::ImportImpl(clang::Decl*) llvm-project/clang/lib/AST/ASTImporter.cpp:8119:0
#25 0x00007feb249c6c53 clang::ASTImporter::Import(clang::Decl*) llvm-project/clang/lib/AST/ASTImporter.cpp:8281:0
#26 0x00007feb249c764d clang::ASTImporter::ImportContext(clang::DeclContext*) llvm-project/clang/lib/AST/ASTImporter.cpp:8387:0
#27 0x00007feb24997aeb clang::ASTNodeImporter::ImportDeclContext(clang::Decl*, clang::DeclContext*&, clang::DeclContext*&) llvm-project/clang/lib/AST/ASTImporter.cpp:1867:0
#28 0x00007feb24996796 clang::ASTNodeImporter::ImportDeclParts(clang::NamedDecl*, clang::DeclContext*&, clang::DeclContext*&, clang::DeclarationName&, clang::NamedDecl*&, clang::SourceLocation&) llvm-project/clang/lib/AST/ASTImporter.cpp:1624:0
#29 0x00007feb2499d9ae clang::ASTNodeImporter::VisitRecordDecl(clang::RecordDecl*) llvm-project/clang/lib/AST/ASTImporter.cpp:2737:0
#30 0x00007feb24a22700 clang::declvisitor::Base<std::add_pointer, clang::ASTNodeImporter, llvm::Expected<clang::Decl*> >::VisitCXXRecordDecl(clang::CXXRecordDecl*) build/Debug/tools/clang/include/clang/AST/DeclNodes.inc:263:0
#31 0x00007feb249fcf60 clang::declvisitor::Base<std::add_pointer, clang::ASTNodeImporter, llvm::Expected<clang::Decl*> >::Visit(clang::Decl*) build/Debug/tools/clang/include/clang/AST/DeclNodes.inc:263:0
#32 0x00007feb249c5ca1 clang::ASTImporter::ImportImpl(clang::Decl*) llvm-project/clang/lib/AST/ASTImporter.cpp:8119:0
#33 0x00007feb249c6c53 clang::ASTImporter::Import(clang::Decl*) llvm-project/clang/lib/AST/ASTImporter.cpp:8281:0
#34 0x00007feb249e6d4d llvm::Expected<clang::RecordDecl*> clang::ASTNodeImporter::import<clang::RecordDecl>(clang::RecordDecl*) llvm-project/clang/lib/AST/ASTImporter.cpp:165:0
#35 0x00007feb24994c34 clang::ASTNodeImporter::VisitRecordType(clang::RecordType const*) llvm-project/clang/lib/AST/ASTImporter.cpp:1397:0
#36 0x00007feb249fde18 clang::TypeVisitor<clang::ASTNodeImporter, llvm::Expected<clang::QualType> >::Visit(clang::Type const*) build/Debug/tools/clang/include/clang/AST/TypeNodes.inc:69:0
#37 0x00007feb249c5f78 clang::ASTImporter::Import(clang::QualType) llvm-project/clang/lib/AST/ASTImporter.cpp:8152:0
#38 0x00007feb249c60fa clang::ASTImporter::Import(clang::TypeSourceInfo*) llvm-project/clang/lib/AST/ASTImporter.cpp:8168:0
#39 0x00007feb249e4d3f llvm::Expected<clang::TypeSourceInfo*> clang::ASTNodeImporter::import<clang::TypeSourceInfo>(clang::TypeSourceInfo*) llvm-project/clang/lib/AST/ASTImporter.cpp:165:0
#40 0x00007feb249ae4b8 clang::ASTNodeImporter::VisitTemplateTypeParmDecl(clang::TemplateTypeParmDecl*) llvm-project/clang/lib/AST/ASTImporter.cpp:5262:0
#41 0x00007feb249fcfb4 clang::declvisitor::Base<std::add_pointer, clang::ASTNodeImporter, llvm::Expected<clang::Decl*> >::Visit(clang::Decl*) build/Debug/tools/clang/include/clang/AST/DeclNodes.inc:293:0
#42 0x00007feb249c5ca1 clang::ASTImporter::ImportImpl(clang::Decl*) llvm-project/clang/lib/AST/ASTImporter.cpp:8119:0
#43 0x00007feb249c6c53 clang::ASTImporter::Import(clang::Decl*) llvm-project/clang/lib/AST/ASTImporter.cpp:8281:0
#44 0x00007feb249ee1e5 llvm::Expected<clang::NamedDecl*> clang::ASTNodeImporter::import<clang::NamedDecl>(clang::NamedDecl*) llvm-project/clang/lib/AST/ASTImporter.cpp:165:0
#45 0x00007feb24a0a278 llvm::Error clang::ASTNodeImporter::ImportArrayChecked<clang::NamedDecl* const*, clang::NamedDecl**>(clang::NamedDecl* const*, clang::NamedDecl* const*, clang::NamedDecl**) llvm-project/clang/lib/AST/ASTImporter.cpp:653:0
#46 0x00007feb249e3b1d llvm::Error clang::ASTNodeImporter::ImportContainerChecked<clang::TemplateParameterList, llvm::SmallVector<clang::NamedDecl*, 4u> >(clang::TemplateParameterList const&, llvm::SmallVector<clang::NamedDecl*, 4u>&) llvm-project/clang/lib/AST/ASTImporter.cpp:669:0
#47 0x00007feb2498e7c5 llvm::Expected<clang::TemplateParameterList*> clang::ASTNodeImporter::import<clang::TemplateParameterList>(clang::TemplateParameterList*) llvm-project/clang/lib/AST/ASTImporter.cpp:747:0
#48 0x00007feb249af31f clang::ASTNodeImporter::VisitClassTemplateDecl(clang::ClassTemplateDecl*) llvm-project/clang/lib/AST/ASTImporter.cpp:5412:0
#49 0x00007feb249fce9c clang::declvisitor::Base<std::add_pointer, clang::ASTNodeImporter, llvm::Expected<clang::Decl*> >::Visit(clang::Decl*) build/Debug/tools/clang/include/clang/AST/DeclNodes.inc:207:0
#50 0x00007feb249c5ca1 clang::ASTImporter::ImportImpl(clang::Decl*) llvm-project/clang/lib/AST/ASTImporter.cpp:8119:0
#51 0x00007feb249c6c53 clang::ASTImporter::Import(clang::Decl*) llvm-project/clang/lib/AST/ASTImporter.cpp:8281:0
#52 0x00007feb249eb455 llvm::Error clang::ASTNodeImporter::importInto<clang::ClassTemplateDecl>(clang::ClassTemplateDecl*&, clang::ClassTemplateDecl*) llvm-project/clang/lib/AST/ASTImporter.cpp:155:0
#53 0x00007feb2499e802 clang::ASTNodeImporter::VisitRecordDecl(clang::RecordDecl*) llvm-project/clang/lib/AST/ASTImporter.cpp:2877:0
#54 0x00007feb24a22700 clang::declvisitor::Base<std::add_pointer, clang::ASTNodeImporter, llvm::Expected<clang::Decl*> >::VisitCXXRecordDecl(clang::CXXRecordDecl*) build/Debug/tools/clang/include/clang/AST/DeclNodes.inc:263:0
#55 0x00007feb249fcf60 clang::declvisitor::Base<std::add_pointer, clang::ASTNodeImporter, llvm::Expected<clang::Decl*> >::Visit(clang::Decl*) build/Debug/tools/clang/include/clang/AST/DeclNodes.inc:263:0
#56 0x00007feb249c5ca1 clang::ASTImporter::ImportImpl(clang::Decl*) llvm-project/clang/lib/AST/ASTImporter.cpp:8119:0
#57 0x00007feb249c6c53 clang::ASTImporter::Import(clang::Decl*) llvm-project/clang/lib/AST/ASTImporter.cpp:8281:0
#58 0x00007feb249f3d21 llvm::Error clang::ASTNodeImporter::importInto<clang::CXXRecordDecl>(clang::CXXRecordDecl*&, clang::CXXRecordDecl*) llvm-project/clang/lib/AST/ASTImporter.cpp:155:0
#59 0x00007feb249af273 clang::ASTNodeImporter::VisitClassTemplateDecl(clang::ClassTemplateDecl*) llvm-project/clang/lib/AST/ASTImporter.cpp:5407:0
#60 0x00007feb249fce9c clang::declvisitor::Base<std::add_pointer, clang::ASTNodeImporter, llvm::Expected<clang::Decl*> >::Visit(clang::Decl*) build/Debug/tools/clang/include/clang/AST/DeclNodes.inc:207:0
#61 0x00007feb249c5ca1 clang::ASTImporter::ImportImpl(clang::Decl*) llvm-project/clang/lib/AST/ASTImporter.cpp:8119:0
#62 0x00007feb249c6c53 clang::ASTImporter::Import(clang::Decl*) llvm-project/clang/lib/AST/ASTImporter.cpp:8281:0
#63 0x00007feb249e53c9 llvm::Expected<clang::Decl*> clang::ASTNodeImporter::import<clang::Decl>(clang::Decl*) llvm-project/clang/lib/AST/ASTImporter.cpp:165:0
#64 0x00007feb2499735e clang::ASTNodeImporter::ImportDeclContext(clang::DeclContext*, bool) llvm-project/clang/lib/AST/ASTImporter.cpp:1761:0
#65 0x00007feb2499b408 clang::ASTNodeImporter::VisitNamespaceDecl(clang::NamespaceDecl*) llvm-project/clang/lib/AST/ASTImporter.cpp:2385:0
#66 0x00007feb249fcd4c clang::declvisitor::Base<std::add_pointer, clang::ASTNodeImporter, llvm::Expected<clang::Decl*> >::Visit(clang::Decl*) build/Debug/tools/clang/include/clang/AST/DeclNodes.inc:111:0
#67 0x00007feb249c5ca1 clang::ASTImporter::ImportImpl(clang::Decl*) llvm-project/clang/lib/AST/ASTImporter.cpp:8119:0
#68 0x00007feb249c6c53 clang::ASTImporter::Import(clang::Decl*) llvm-project/clang/lib/AST/ASTImporter.cpp:8281:0
#69 0x00007feb249c764d clang::ASTImporter::ImportContext(clang::DeclContext*) llvm-project/clang/lib/AST/ASTImporter.cpp:8387:0
#70 0x00007feb24997aeb clang::ASTNodeImporter::ImportDeclContext(clang::Decl*, clang::DeclContext*&, clang::DeclContext*&) llvm-project/clang/lib/AST/ASTImporter.cpp:1867:0
#71 0x00007feb24996796 clang::ASTNodeImporter::ImportDeclParts(clang::NamedDecl*, clang::DeclContext*&, clang::DeclContext*&, clang::DeclarationName&, clang::NamedDecl*&, clang::SourceLocation&) llvm-project/clang/lib/AST/ASTImporter.cpp:1624:0
#72 0x00007feb249aee01 clang::ASTNodeImporter::VisitClassTemplateDecl(clang::ClassTemplateDecl*) llvm-project/clang/lib/AST/ASTImporter.cpp:5355:0
#73 0x00007feb249fce9c clang::declvisitor::Base<std::add_pointer, clang::ASTNodeImporter, llvm::Expected<clang::Decl*> >::Visit(clang::Decl*) build/Debug/tools/clang/include/clang/AST/DeclNodes.inc:207:0
#74 0x00007feb249c5ca1 clang::ASTImporter::ImportImpl(clang::Decl*) llvm-project/clang/lib/AST/ASTImporter.cpp:8119:0
#75 0x00007feb249c6c53 clang::ASTImporter::Import(clang::Decl*) llvm-project/clang/lib/AST/ASTImporter.cpp:8281:0
#76 0x000055b24844006d clang::ast_matchers::ASTImporterTestBase::TU::import(std::shared_ptr<clang::ASTImporterSharedState> const&, clang::ASTUnit*, clang::Decl*) llvm-project/clang/unittests/AST/ASTImporterFixtures.cpp:83:0
#77 0x000055b248440db9 clang::ast_matchers::ASTImporterTestBase::Import(clang::Decl*, clang::TestLanguage) llvm-project/clang/unittests/AST/ASTImporterFixtures.cpp:199:0
#78 0x000055b2484dc5d6 clang::ClassTemplateDecl* clang::ast_matchers::ASTImporterTestBase::Import<clang::ClassTemplateDecl>(clang::ClassTemplateDecl*, clang::TestLanguage) llvm-project/clang/unittests/AST/ASTImporterFixtures.h:185:0
#79 0x000055b2484aa73c clang::ast_matchers::ASTImporterOptionSpecificTestBase_ImportOfTemplatedDeclWhenPreviousDeclHasNoDescribedTemplateSet_Test::TestBody() llvm-project/clang/unittests/AST/ASTImporterTest.cpp:6180:0
#80 0x00007feb235f3a04 void testing::internal::HandleSehExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) llvm-project/llvm/utils/unittest/googletest/src/gtest.cc:2402:0
#81 0x00007feb235ecda2 void testing::internal::HandleExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) llvm-project/llvm/utils/unittest/googletest/src/gtest.cc:2455:0
#82 0x00007feb235d3666 testing::Test::Run() llvm-project/llvm/utils/unittest/googletest/src/gtest.cc:2481:0
#83 0x00007feb235d3e2a testing::TestInfo::Run() llvm-project/llvm/utils/unittest/googletest/src/gtest.cc:2660:0
#84 0x00007feb235d441e testing::TestCase::Run() llvm-project/llvm/utils/unittest/googletest/src/gtest.cc:2773:0
#85 0x00007feb235da33c testing::internal::UnitTestImpl::RunAllTests() llvm-project/llvm/utils/unittest/googletest/src/gtest.cc:4647:0
#86 0x00007feb235f4cbf bool testing::internal::HandleSehExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) llvm-project/llvm/utils/unittest/googletest/src/gtest.cc:2404:0
#87 0x00007feb235ed98b bool testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) llvm-project/llvm/utils/unittest/googletest/src/gtest.cc:2455:0
#88 0x00007feb235d91c5 testing::UnitTest::Run() llvm-project/llvm/utils/unittest/googletest/src/gtest.cc:4260:0
#89 0x00007feb277c5c36 RUN_ALL_TESTS() llvm-project/llvm/utils/unittest/googletest/include/gtest/gtest.h:2234:0
#90 0x00007feb277c5b42 main llvm-project/llvm/utils/unittest/UnitTestMain/TestMain.cpp:51:0
#91 0x00007feb226d4bf7 __libc_start_main /build/glibc-S9d2JN/glibc-2.27/csu/../csu/libc-start.c:344:0
#92 0x000055b2483f51fa _start (./tools/clang/unittests/AST/ASTTests+0xe31fa)
Aborted (core dumped)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D94067/new/
https://reviews.llvm.org/D94067
More information about the cfe-commits
mailing list