[PATCH] D72281: [Matrix] Add matrix type to Clang.

Simon Pilgrim via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat Jan 2 07:02:11 PST 2021


RKSimon added inline comments.


================
Comment at: clang/lib/Sema/SemaType.cpp:7855
+      return;
+    RowsExpr = Columns.get();
+  } else {
----------------
@fhahn Should this be ColsExpr?
```
ColsExpr = Columns.get();
```
Noticed when looking at https://llvm.org/reports/scan-build/report-SemaType.cpp-BuildMatrixType-11-1.html#EndPath


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72281/new/

https://reviews.llvm.org/D72281



More information about the cfe-commits mailing list