[PATCH] D92600: [ASTImporter] Add support for importing GenericSelectionExpr AST nodes.

Tom Roeder via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Dec 14 15:35:25 PST 2020


tmroeder added a comment.

In D92600#2453124 <https://reviews.llvm.org/D92600#2453124>, @tmroeder wrote:

> Change the DeclMatcher.h test code to expose the ability to not assert on null Nodes from a match.
>
> This allows the tests for GenericSelectionExpr to handle the null case on Windows themselves without crashing, and to still work correctly and test the appropriate functionality on Linux.

It looks like this change finally fixed the Windows tests that I was breaking. However, I'm now touching new parts of the test framework to make this work. Please take a look at and let me know what you think.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92600/new/

https://reviews.llvm.org/D92600



More information about the cfe-commits mailing list