[PATCH] D93220: [clangd] Add error handling (elog) in code completion.

Nathan James via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Dec 14 15:07:04 PST 2020


njames93 added inline comments.


================
Comment at: clang-tools-extra/clangd/CodeComplete.cpp:187-188
+      if (auto Header = headerToInsertIfAllowed(Opts)) {
+        auto HeaderFile = toHeaderFile(*Header, FileName);
+        if (HeaderFile) {
           if (auto Spelled =
----------------
This can stay as 1 line, The condition variable in an if has lifetime throughout the then/else branch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93220/new/

https://reviews.llvm.org/D93220



More information about the cfe-commits mailing list