[PATCH] D92662: [Clang][Coroutine] Drop const attribute on pthread_self when coroutine is enabled

Thu Dec 10 16:09:31 PST 2020

lxfind added a comment.

In D92662#2446777 <https://reviews.llvm.org/D92662#2446777>, @jyknight wrote:

> I don't think we should change the meaning of `__attribute__((const))` to exclude depending on thread-id.
>
> However, if we do want to do so, and call the existing uses of `__attribute__((const))` in glibc invalid, we need to special case many more functions. Looking through it a little, I see `__errno_location`, `__rpc_thread_variables`, `__ctype_b_loc`, `__ctype_tolower_loc`, `__ctype_toupper_loc`, `__libc_tsd_address`...and I gave up looking after that.

Thanks for pointing it out. I didn't realize there are so many of them.
Your proposals in the llvm-dev thread sound very promising. Let me think them over.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92662/new/

https://reviews.llvm.org/D92662